Skip to content

Conversation

@drvinceknight
Copy link
Member

This PR simply adds a couple of commits to @mojones's #398 merging this would automatically merge in #398 (because github is cool).

This really only needs to be ok'd by @marcharper as #398 has gone through a detailed review by him and I. This is a minor review change:

  • Adding an example to docstring
  • Fixing a test (unless I'm mistaken the previous version was not running one set of tests)
  • Changing something back to string notation for clarity (Marc: you might well have had a reason for changing this).

mojones and others added 30 commits October 27, 2015 16:25
Some comments, tests, and style edits for the LookerUp strategies
- not stricly necessary but verbose.
Also including an example with m=3 and n=2.
@drvinceknight drvinceknight changed the title Mojones master this adds to #398 Mojones-master this adds to #398 Nov 3, 2015
@marcharper
Copy link
Member

Looks fine to me!

meatballs added a commit that referenced this pull request Nov 3, 2015
@meatballs meatballs merged commit 930c22b into master Nov 3, 2015
@meatballs meatballs deleted the mojones-master branch November 3, 2015 14:41
@meatballs meatballs removed the ready label Nov 3, 2015
@meatballs
Copy link
Member

and there we have it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants