Adding in some examples for particular failures. #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to be an issue with MindReader + Backstabber and ThueMorse...
| # Removing this as Hypothesis seems to have found a py2 bug. | ||
| # This is a temporary fix. For some reason mind reader seems to fail a test. | ||
| @given(s=lists(sampled_from([s for s in axelrod.strategies if s not in axelrod.cheating_strategies]), | ||
| # The @given below will run tests if the examples on lines 123... are |
Member
Author
There was a problem hiding this comment.
Run and pass. This is not really useful, just in case anyone plays with this and wants to get tests passing.
Member
Author
|
I want to play with those things locally. Will probably merge this with #468. If I understand correctly that should get both examples here to pass. I'll confirm that all locally and after merging all bug fixes I'll open an issue so that we can discuss the changes post mortem so to speak. To make sure everyone knows what's going on :) Got to walk to 🐶 now but will do this during the morning. |
Seems to be an issue with MindReader + Backstabber and ThueMorse...
Conflicts: axelrod/tests/unit/test_tournament.py
Member
Author
|
Merging as all tests pass. |
drvinceknight
added a commit
that referenced
this pull request
Feb 24, 2016
Adding in some examples for particular failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is relevant to #465.
Seems to be an issue with MindReader + Backstabber and ThueMorse...