fix: bar revealed on fullscreen when monitor did not have focus#49
Merged
Axenide merged 2 commits intoAxenide:mainfrom Feb 10, 2026
Merged
fix: bar revealed on fullscreen when monitor did not have focus#49Axenide merged 2 commits intoAxenide:mainfrom
Axenide merged 2 commits intoAxenide:mainfrom
Conversation
Owner
|
Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable
ToplevelManager.activeTopleveldoes only give toplevel on monitor where mouse/focus is. When pin is active and mouse leaves monitor with fullscreen application, the bar reveals itself when it should not. ThehyprlandMonitor.activeWorkspace.toplevels.valuesvariable only gives toplevels that are relevant to each bar.A diffrent fix could be:
readonly property bool activeWindowFullscreen: {if (!hyprlandMonitor) return false;return hyprlandMonitor.hasFullscreen == true;}We can skip the loop but Hyprland has 2 definitions of fullscreen, where
hyprlandMonitor.hasFullscreen == true;triggers on both definitions. The problem with this is if you trigger the semi fullscreen state. Then the bar hides itself but it still takes up space on the desktop. WhileWayland.toplevel.fullscreenonly triggers on real fullscreen.The Notch did hide on the semi fullscreen and ScreenCorners complained about bind loop. That is fixed with this patch