axtract.py completely changed #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsarra-ax
requested changes
Jan 7, 2025
Contributor
lsarra-ax
left a comment
lsarra-ax
left a comment
There was a problem hiding this comment.
Hi Tymek, there are a few issues with dependencies. hypernetx can be added manually as a dependency in the plyground, printing function from ax_core.utils should probably be added as an extra module (or copied and pasted here)
src/axiomatic/axtract.py
Outdated
| import hypernetx as hnx | ||
| import matplotlib.pyplot as plt | ||
| import re | ||
| from ax_core.utils import printing |
src/axiomatic/axtract.py
Outdated
| from IPython.display import display # type: ignore | ||
| from IPython.display import display, Math # type: ignore | ||
| from dataclasses import dataclass, field | ||
| import hypernetx as hnx |
Contributor
There was a problem hiding this comment.
This dependency becomes a requirement of the axiomatic package (or we require the user to install it manually with # type: ignore
Contributor
Author
There was a problem hiding this comment.
hypernetx should be included in my opinion, if not i will add a cell with pip installation
lsarra-ax
approved these changes
Jan 8, 2025
Contributor
|
@tymekaxai please describe what this actually does in the title |
Contributor
Author
|
ok next time I will be more careful about that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new features in extract.py to serve extract cookbook