Skip to content

Clean up post-install script#249

Merged
killenheladagen merged 1 commit intomainfrom
post-install-cleanup
May 6, 2024
Merged

Clean up post-install script#249
killenheladagen merged 1 commit intomainfrom
post-install-cleanup

Conversation

@killenheladagen
Copy link
Contributor

  • Use variables to reduce code duplication.
  • Use variables to increase readability.
  • Break comment line that exceeded 100 characters.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

Base automatically changed from sd-owner to main May 2, 2024 07:19
* Use variables to reduce code duplication.
* Use variables to increase readability.
* Break comment line that exceeded 100 characters.
@killenheladagen killenheladagen force-pushed the post-install-cleanup branch from 18f0829 to 521ea41 Compare May 2, 2024 07:20
@killenheladagen killenheladagen marked this pull request as ready for review May 2, 2024 07:21
@killenheladagen killenheladagen requested review from a team as code owners May 2, 2024 07:21
@killenheladagen killenheladagen merged commit cd4f394 into main May 6, 2024
@killenheladagen killenheladagen deleted the post-install-cleanup branch May 6, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments