This repository was archived by the owner on Mar 25, 2025. It is now read-only.
refactor: split out selector from base select#11
Merged
Tigge merged 1 commit intoAxisCommunications:mainfrom Feb 1, 2021
Merged
refactor: split out selector from base select#11Tigge merged 1 commit intoAxisCommunications:mainfrom
Tigge merged 1 commit intoAxisCommunications:mainfrom
Conversation
Tigge
force-pushed
the
selector-refactoring
branch
2 times, most recently
from
206ea4f to
fde1250
Compare
Tigge
force-pushed
the
selector-refactoring
branch
from
fde1250 to
c4f1585
Compare
boilund
reviewed
Feb 1, 2021
| const handleFocusOut: React.EventHandler<React.FocusEvent> = useCallback( | ||
| e => { | ||
| e.persist() | ||
| console.log(e) |
The selector itself could be reused to make other types of selects such as a larger area, or a grid of things. This splits out the selector part from BaseSelect into BaseSelectSelector. In addition this adds a forwardRef to Paper so it can be reused in dropdowns.
Tigge
force-pushed
the
selector-refactoring
branch
from
c4f1585 to
53e55b2
Compare
boilund
approved these changes
Feb 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The selector itself could be reused to make other types of selects such
as a larger area, or a grid of things. This splits out the selector part
from BaseSelect into BaseSelectSelector.
In addition this adds a forwardRef to Paper so it can be reused in
dropdowns.