This repository was archived by the owner on Mar 25, 2025. It is now read-only.
fix(slider): align min and max tick labels#137
Merged
steabert merged 1 commit intoAxisCommunications:mainfrom Sep 6, 2021
Merged
fix(slider): align min and max tick labels#137steabert merged 1 commit intoAxisCommunications:mainfrom
steabert merged 1 commit intoAxisCommunications:mainfrom
Conversation
steabert
suggested changes
Sep 3, 2021
Member
steabert
left a comment
steabert
left a comment
There was a problem hiding this comment.
Looks OK but please explain the fix in the commit message body.
danielkaxis
force-pushed
the
sliderticklabelfix
branch
2 times, most recently
from
0d24df0 to
2b4baaa
Compare
Tick labels aligned at minimum and maximum values are now aligned left and right of its container. Previously they were centered to its value which caused issues with long text.
danielkaxis
force-pushed
the
sliderticklabelfix
branch
from
2b4baaa to
87da138
Compare
steabert
approved these changes
Sep 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a fix that aligns minimum and maximum labels left and right.
Closes #135