Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

fix(toggleButtonGroup): color and border don't overflow now#149

Merged
Tigge merged 1 commit intoAxisCommunications:mainfrom
maur0xis:fix-TBG
Oct 20, 2021
Merged

fix(toggleButtonGroup): color and border don't overflow now#149
Tigge merged 1 commit intoAxisCommunications:mainfrom
maur0xis:fix-TBG

Conversation

@maur0xis
Copy link
Copy Markdown
Contributor

@maur0xis maur0xis commented Sep 28, 2021

By adding box-sizing: border-box; the component gets the correct behavior. Fixes #91

Current look:
Peek 2021-09-28 10-57

tested with yarn link

@maur0xis maur0xis force-pushed the fix-TBG branch 2 times, most recently from 0e0a1bc to 9f18836 Compare September 28, 2021 09:37
@Tigge
Copy link
Copy Markdown
Collaborator

Tigge commented Sep 29, 2021

This changes the appearance a bit, which we don't want:
image

I just realized this is due to us not setting box-sizing: border-box;. Commonly * { box-sizing: border-box; } is used in modern projects. That is what we are using in the documentation as well. But that should not be required.

@maur0xis
Copy link
Copy Markdown
Contributor Author

I just realized this is due to us not setting box-sizing: border-box;.

Added

@Tigge Tigge merged commit cf56ce8 into AxisCommunications:main Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toggle Button Group component does not have the correct CSS behavior

2 participants