Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

feat(toggleButtonGroup): add exclusiveness to options#150

Merged
boilund merged 1 commit intoAxisCommunications:mainfrom
brian-chano:ToggleButtonGroupExclusive
Oct 15, 2021
Merged

feat(toggleButtonGroup): add exclusiveness to options#150
boilund merged 1 commit intoAxisCommunications:mainfrom
brian-chano:ToggleButtonGroupExclusive

Conversation

@brian-chano
Copy link
Copy Markdown
Collaborator

@brian-chano brian-chano commented Oct 1, 2021

  • Adds an exclusive boolean prop to the ToggleButtonGroup. When set, if an option is already selected, any persistent toggles on the same option will be ignored.
    toggleButtonExclusive

@brian-chano brian-chano force-pushed the ToggleButtonGroupExclusive branch from 11676d4 to 57db621 Compare October 1, 2021 09:12
Copy link
Copy Markdown
Collaborator

@boilund boilund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update test as well? (/ToggleButtonGroup/index.test.tsx and cypress test under ui-test folder) Also please add a short screencast in Conversation in this PR to show how this works.

@brian-chano brian-chano force-pushed the ToggleButtonGroupExclusive branch 2 times, most recently from c5537a7 to 656ad38 Compare October 15, 2021 11:15
@brian-chano
Copy link
Copy Markdown
Collaborator Author

Could you update test as well? (/ToggleButtonGroup/index.test.tsx and cypress test under ui-test folder) Also please add a short screencast in Conversation in this PR to show how this works.

@boilund Added tests

- Adds an exclusive boolean prop to the ToggleButtonGroup.
  When set, if an option is already selected, any persistent
  toggles on the same option will be ignored.
@brian-chano brian-chano force-pushed the ToggleButtonGroupExclusive branch from 656ad38 to f06a642 Compare October 15, 2021 11:39
@boilund boilund merged commit ba59742 into AxisCommunications:main Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants