This repository was archived by the owner on Mar 25, 2025. It is now read-only.
fix(popOver): reposition PopOver when it is resized#157
Merged
Tigge merged 1 commit intoAxisCommunications:mainfrom Oct 29, 2021
Merged
fix(popOver): reposition PopOver when it is resized#157Tigge merged 1 commit intoAxisCommunications:mainfrom
Tigge merged 1 commit intoAxisCommunications:mainfrom
Conversation
Collaborator
|
Instead of this which seems a bit random, we instead could have an additional resize observer on the popover that could trigger a reposition. That would also solve #86 as well. |
brian-chano
force-pushed
the
popOverposition
branch
from
e32e86e to
288dd98
Compare
Collaborator
Author
Tigge
suggested changes
Oct 27, 2021
brian-chano
force-pushed
the
popOverposition
branch
3 times, most recently
from
8222b4b to
fa66ab2
Compare
brian-chano
changed the title
- Fixes an issue where a `PopOver` was incorrectly positioned after a resize
brian-chano
force-pushed
the
popOverposition
branch
from
fa66ab2 to
0d5cbfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PopOverwas incorrectly positioned after a resize