This repository was archived by the owner on Mar 25, 2025. It is now read-only.
fix(tooltip): use pointerdown event for touch#233
Merged
boilund merged 1 commit intoAxisCommunications:mainfrom Jun 27, 2022
Merged
fix(tooltip): use pointerdown event for touch#233boilund merged 1 commit intoAxisCommunications:mainfrom
boilund merged 1 commit intoAxisCommunications:mainfrom
Conversation
Using pointerdown event instead of click and toggle only if pointerType is not `mouse` Co-authored-by: Mauricio Espinoza <Mauricio.Espinoza@axis.com> Co-authored-by: Victor Ingvarsson <Victor.Ingvarsson@axis.com>
boilund
reviewed
Jun 27, 2022
Collaborator
boilund
left a comment
boilund
left a comment
There was a problem hiding this comment.
It looks good. Did you confirm that it solves the issue?
Collaborator
Author
|
@boilund Yes, double-checked again and works fine. |
boilund
approved these changes
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using pointerdown event instead of click
and toggle only if pointerType is not
mouseCo-authored-by: Mauricio Espinoza Mauricio.Espinoza@axis.com
Co-authored-by: Victor Ingvarsson Victor.Ingvarsson@axis.com
Checklist before requesting a review