Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

fix(dialog): make dialogs fit on small screens#235

Merged
Tigge merged 1 commit intoAxisCommunications:mainfrom
HannesBergenfalk:dialogmaxwidth
Aug 23, 2022
Merged

fix(dialog): make dialogs fit on small screens#235
Tigge merged 1 commit intoAxisCommunications:mainfrom
HannesBergenfalk:dialogmaxwidth

Conversation

@HannesBergenfalk
Copy link
Copy Markdown

Adds max-width to dialogs so that they doe not overflow if viewed
on a small screen, such as on a moblie device

Describe your changes

It is 1 row added so there is not much to summarize. The context is a use case within AXIS Device Assistant (ADA), configuring a connection to a wireless network. Unlike most use cases in ADA this is meant to be done on a mobile device. At the end of the process there is a confirmation dialog and with the current code it overflows such that . See attached images

dialogoverflow
installmodeconfirm

Issue ticket number and link

  • Fixes #(issue)

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

Adds max-width to dialogs so that they doe not overflow if viewed
on a small screen, such as on a moblie device
@HannesBergenfalk HannesBergenfalk requested a review from Tigge as a code owner July 20, 2022 11:24
@Tigge Tigge merged commit 28d9363 into AxisCommunications:main Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants