This repository was archived by the owner on Mar 25, 2025. It is now read-only.
fix(dialog): make dialogs fit on small screens#235
Merged
Tigge merged 1 commit intoAxisCommunications:mainfrom Aug 23, 2022
Merged
fix(dialog): make dialogs fit on small screens#235Tigge merged 1 commit intoAxisCommunications:mainfrom
Tigge merged 1 commit intoAxisCommunications:mainfrom
Conversation
Adds max-width to dialogs so that they doe not overflow if viewed on a small screen, such as on a moblie device
Tigge
approved these changes
Aug 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds max-width to dialogs so that they doe not overflow if viewed
on a small screen, such as on a moblie device
Describe your changes
It is 1 row added so there is not much to summarize. The context is a use case within AXIS Device Assistant (ADA), configuring a connection to a wireless network. Unlike most use cases in ADA this is meant to be done on a mobile device. At the end of the process there is a confirmation dialog and with the current code it overflows such that . See attached images
Issue ticket number and link
Checklist before requesting a review