Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

feat(input): show decimals if step is defined#238

Merged
Tigge merged 1 commit intoAxisCommunications:mainfrom
danielkaxis:numberinputdecimals
Aug 30, 2022
Merged

feat(input): show decimals if step is defined#238
Tigge merged 1 commit intoAxisCommunications:mainfrom
danielkaxis:numberinputdecimals

Conversation

@danielkaxis
Copy link
Copy Markdown
Collaborator

If attribute step is specified, show base values
together with decimals.

Describe your changes

By default a number input element is displaying integers without decimals when step is specified. To improve user experience and make it more clear that the input contains decimal values, show integers with the amount of decimals specified in the step attribute.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@danielkaxis danielkaxis requested a review from Tigge as a code owner August 25, 2022 09:45
@danielkaxis
Copy link
Copy Markdown
Collaborator Author

danielkaxis commented Aug 25, 2022

Not sure why tests are failing, working fine locally.

If attribute step is specified, show base values
together with decimals.
@Tigge Tigge merged commit 846092f into AxisCommunications:main Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NumberInput: Show integer values with decimals

2 participants