Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

feat(tabs)!: add tabs component#239

Merged
boilund merged 1 commit intoAxisCommunications:mainfrom
lekoaf:mt/tabs
Sep 7, 2022
Merged

feat(tabs)!: add tabs component#239
boilund merged 1 commit intoAxisCommunications:mainfrom
lekoaf:mt/tabs

Conversation

@lekoaf
Copy link
Copy Markdown
Member

@lekoaf lekoaf commented Sep 7, 2022 •
edited
Loading

Describe your changes

Add a new Tabs and VerticalTabs (plural) component and removes the Tab and VerticalTab components. I does not make sense to give the user the ability to use Tabs individually, so instead we created a wrapper component which takes the tabs as options instead.

This will also make our PRC => Fluent conversion easier because Fluent has a wrapper component that handles all the clicking and switching logic.

BREAKING CHANGE: replaces Tab and VerticalTab components with Tabs and VerticalTabs components.

Issue ticket number and link

  • Fixes #(issue)

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@lekoaf lekoaf requested a review from Tigge as a code owner September 7, 2022 08:54
@lekoaf lekoaf requested a review from boilund September 7, 2022 08:55
@lekoaf lekoaf self-assigned this Sep 7, 2022
boilund
boilund reviewed Sep 7, 2022
View reviewed changes
Comment thread packages/docs/src/mdx/coreComponents/Tab.mdx Outdated
@lekoaf
Copy link
Copy Markdown
Member Author

lekoaf commented Sep 7, 2022

I forgot to update the Cypress tests. Will do that.

@lekoaf lekoaf force-pushed the mt/tabs branch 3 times, most recently from fe62956 to 1db3231 Compare September 7, 2022 09:42
boilund
boilund approved these changes Sep 7, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@boilund boilund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@boilund
Copy link
Copy Markdown
Collaborator

boilund commented Sep 7, 2022 •
edited
Loading

Looks like Tab.cypress.tsx cannot render Tabs component because '"practical-react-components-core"' has no exported member named 'Tabs' according to VScode error message.
It was nothing. I just needed to build it.
But the test still fails.

boilund
boilund reviewed Sep 7, 2022
View reviewed changes
Comment thread packages/ui-tests/src/coreComponents/Tab.cypress.tsx Outdated
@lekoaf
feat(tabs)!: add tabs component
6999239 
Add a new Tabs and VerticalTabs (plural)
component and removes the Tab and VerticalTab
components.
I does not make sense to give the user the ability
to use Tabs individually, so instead we created
a wrapper component which takes the tabs as options
instead.

This will also make our PRC => Fluent conversion
easier because Fluent has a wrapper component
that handles all the clicking and switching logic.

BREAKING CHANGE: replaces Tab and VerticalTab components
with Tabs and VerticalTabs components.
@boilund boilund merged commit b0dbc73 into AxisCommunications:main Sep 7, 2022
@lekoaf lekoaf deleted the mt/tabs branch September 7, 2022 12:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Tigge Tigge Awaiting requested review from Tigge Tigge is a code owner

1 more reviewer

@boilund boilund boilund approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lekoaf lekoaf

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lekoaf @boilund