fix: extractBashWritePaths rejects garbage paths#14
Merged
George-iam merged 3 commits intomainfrom Apr 6, 2026
Merged
Conversation
Add isValidFilePath filter: rejects bare /, fd-redirect artifacts (0:, 1:, &1), and paths not starting with valid prefixes. Root / added to IGNORED_PATHS. Tests: 11/11 bash-extract, 119/119 full-storage.
Extends merged-PR check from git push only to also cover git commit and git add. Prevents wasted work on stale branches that would require cherry-pick to recover. Refactored: extracted detectBranch and checkMergedBranch helpers from the inline push check. Tests: commit/add/push all BLOCKED on merged branch, allowed on open branch, read-only git commands unaffected, 24/24 safety regression.
Tool description now explicitly states it is ONLY for questions that require user decisions (architectural choices, ambiguous requirements). Includes anti-example to prevent agents from logging bugs or TODOs as open questions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/,1:,0:[;&|]+creates artifacts from2>&1patternsisValidFilePathfilter: rejects bare/, fd-redirect artifacts (0:,1:,&1), paths not starting with valid prefixes/to IGNORED_PATHSTest plan