Skip to content

Change CBOR encoding strategy order to properly detect Jackson 2#136

Merged
CodeDrivenMitch merged 1 commit intomainfrom
135-change-cbor-encoding-strategy-order
Apr 7, 2026
Merged

Change CBOR encoding strategy order to properly detect Jackson 2#136
CodeDrivenMitch merged 1 commit intomainfrom
135-change-cbor-encoding-strategy-order

Conversation

@alex-w0
Copy link
Copy Markdown
Contributor

@alex-w0 alex-w0 commented Apr 2, 2026

Currently, the system checks for Jackson 3 before Jackson 2. Because the Jackson 3 modules are included as standard (non-optional) dependencies in the project, the classpath check for Jackson 3 always evaluates to true.

Consequently, the strategy check never fails, and the framework never reaches the condition to verify if the user is actually running Jackson 2. This can result in the wrong encoding strategy being applied for users who rely on Jackson 2.

@alex-w0 alex-w0 linked an issue Apr 2, 2026 that may be closed by this pull request
@alex-w0 alex-w0 requested a review from CodeDrivenMitch April 2, 2026 06:58
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 2, 2026

Copy link
Copy Markdown
Collaborator

@CodeDrivenMitch CodeDrivenMitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeDrivenMitch CodeDrivenMitch merged commit e5d4ab3 into main Apr 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change CBOR Encoding Strategy order

2 participants