Add ability to observe connection errors#137
Merged
CodeDrivenMitch merged 2 commits intomainfrom Apr 14, 2026
Merged
Conversation
For the new license management it's important to be able to observe that a connection error occurred to trigger a longer leniency period. However, there was no way to propate this information. This PR adds the `onUnreachable` to the `PlatformClientConnectionObserver`, which was renamed from `ClientSettingsObserver` to better reflect its intent. Likewise, renamed `ClientSettingsService` to `PlatformClientConnectionService`.
CodeDrivenMitch
requested review from
MartinPfeffer,
alex-w0,
corradom,
dilgerma and
stefanmirkovic
and removed request for
a team
|
stefanmirkovic
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the new license management it's important to be able to observe that a connection error occurred to trigger a longer leniency period. However, there was no way to propate this information.
This PR adds the
onUnreachableto thePlatformClientConnectionObserver, which was renamed fromClientSettingsObserverto better reflect its intent. Likewise, renamedClientSettingsServicetoPlatformClientConnectionService.