APIGOV-32465 - Fix to avoid deadlocks on watch request and event channel#1026
Merged
vivekschauhan merged 12 commits intomainfrom Apr 27, 2026
Merged
APIGOV-32465 - Fix to avoid deadlocks on watch request and event channel#1026vivekschauhan merged 12 commits intomainfrom
vivekschauhan merged 12 commits intomainfrom
Conversation
…and healthcheck failure
- Fixes from Jason to remove mutex and logging updates - Fix race in healthchecker - Fix deadlock on interval job when marking it as stopped - Added/updated tests for watch manager
…ellation for RegisterWatch
vivekschauhan
requested review from
alrosca,
dfeldick,
dgghinea,
jcollins-axway and
sbolosan
as code owners
|
|
||
| // RegisterWatch registers a watch topic for polling events and publishing events on a channel | ||
| func (m *pollExecutor) RegisterWatch(eventChan chan *proto.Event, errChan chan error) { | ||
| func (m *pollExecutor) RegisterWatch(eventChan chan *proto.Event) { |
Collaborator
There was a problem hiding this comment.
love how this func was simplified
jcollins-axway
previously approved these changes
Apr 24, 2026
jcollins-axway
approved these changes
Apr 27, 2026
jcollins-axway
pushed a commit
that referenced
this pull request
Apr 30, 2026
…nel (#1026) * APIGOV-32465 - Fix to avoid deadlocks on watch request and event channel * APIGOV-32465 - initial watch request lock wait using the context * APIGOV-32465 - fix race on watch context cancel and writing error to channel * APIGOV-32465 - fix race on writing watch request during registration and healthcheck failure * APIGOV-32465 - return error when stream is not initialized for healthcheck * APIGOV-32465 - timeout on initial watch request * APIGOV-32465 - do not remove clients while checking status * APIGOV-32465 - defer setting isInitialized after setting to true * APIGOV-32465 - fix test * APIGOV-32465 - data race and lock issues on jobs - Fixes from Jason to remove mutex and logging updates - Fix race in healthchecker - Fix deadlock on interval job when marking it as stopped - Added/updated tests for watch manager * APIGOV-32465 - Refactoring to replace error channel with context cancellation for RegisterWatch * APIGOV-32465 - review fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.