APIGOV-SDB01 - fix deatlock found in unit test#1033
Merged
Conversation
sbolosan
requested review from
alrosca,
dfeldick,
dgghinea,
jcollins-axway and
vivekschauhan
as code owners
vivekschauhan
approved these changes
Apr 30, 2026
jcollins-axway
approved these changes
Apr 30, 2026
alrosca
approved these changes
Apr 30, 2026
jcollins-axway
pushed a commit
that referenced
this pull request
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resetEndpointSampling was holding endpointsLock across a call to stopCounterResetter(), which does a blocking channel send. This caused a deadlock: the channel receiver (samplingCounterReset) was blocked on samplingLock, which was held by ShouldSampleTransaction goroutines that were in turn waiting on endpointsLock.
Fixed by extracting hasRemainingEndpoints() to scope the lock to just the map read — defer now fires at the right time, and the channel send in stopCounterResetter() happens completely lock-free.