fix: originalKeys values include the full source path prefix when Options.Root is set,#49
Merged
Merged
Conversation
…ions.Root is set,
There was a problem hiding this comment.
Pull request overview
This PR fixes provenance key mapping for sourcefile when Options.Root is used, so originalKeys reports the full dot-path within the source file (even though returned flattened keys remain relative to the selected subtree).
Changes:
- Prefix
originalKeysvalues withOptions.RootwhenRootis set. - Update
TestFileSource_Load_Rootexpectations to assert the full original dot-path for returned keys.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
sourcefile/file.go |
Adjusts LoadWithKeys to prepend Options.Root to originalKeys values, preserving full source-path provenance. |
sourcefile/file_test.go |
Updates root-loading test to validate the new originalKeys behavior for multiple keys. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Azhovan
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address copilot reviews here