fix(build): add CultureInfo.InvariantCulture to int.Parse in SmtpEmailService#23
Merged
Morgana-Claw merged 1 commit intomasterfrom Apr 1, 2026
Merged
Conversation
…lService CA1305 becomes an error in Release mode because Directory.Build.props sets TreatWarningsAsErrors=true for non-test projects in Release. The Docker build on Render uses -c Release, so this caused the deploy to fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Docker build on Render failed for commit 46510df because SmtpEmailService.SendWelcomeEmailToUserAsync used int.Parse(string) without specifying CultureInfo.InvariantCulture.
In Directory.Build.props, TreatWarningsAsErrors is enabled for Release mode in non-test projects. The CA1305 analyzer warning became a build error in Release mode, causing the Docker build to fail.
Fix
Added CultureInfo.InvariantCulture to the int.Parse call on line 64 of SmtpEmailService.SendWelcomeEmailToUserAsync, consistent with how it was already done in SendWelcomeEmailAsync (line 12).
Verification