refactor: introduce ReedConfig dataclass and consolidate print_fn boi…#6
Merged
refactor: introduce ReedConfig dataclass and consolidate print_fn boi…#6
Conversation
…lerplate - Add frozen ReedConfig dataclass (model, speed, volume, silence, output) replacing argparse.Namespace in speak_text() core function - Convert argparse Namespace to ReedConfig at CLI boundary in main() - get_text() and _should_enter_interactive() keep argparse.Namespace (they use CLI-only fields: text, file, clipboard) - Remove 'if print_fn is None: print_fn = console.print' pattern from 7 functions; use console.print as default parameter value instead - Add _make_config() test helper for speak_text tests - All 30 tests pass Amp-Thread-ID: https://ampcode.com/threads/T-019c6133-6f61-7629-900a-216a4ac543a5 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lerplate