Skip to content

Implement portal#3

Merged
sysnote8main merged 57 commits intover/1.21.11from
feature/portal
Mar 22, 2026
Merged

Implement portal#3
sysnote8main merged 57 commits intover/1.21.11from
feature/portal

Conversation

@sysnote8main
Copy link
Copy Markdown

@sysnote8main sysnote8main commented Mar 16, 2026

  • プリズマリンをネザーゲートの形に囲んで火打ち石と打ち金で着火すると、ゲートが開きます。
  • 帰りは、escキーを押して、back to islandを押せば帰れます

@sysnote8main
Copy link
Copy Markdown
Author

destがおかしいので直す

@sysnote8main sysnote8main marked this pull request as ready for review March 19, 2026 14:34
@sysnote8main sysnote8main requested a review from tksimeji March 19, 2026 14:35
@sysnote8main
Copy link
Copy Markdown
Author

これでマージしても良いレベルになったかな...?

@tksimeji
Copy link
Copy Markdown
Member

出かけているので帰宅後(夜)か明日レビューします!

@sysnote8main
Copy link
Copy Markdown
Author

これエンド層にテレポートしちゃってるな...

@tksimeji
Copy link
Copy Markdown
Member

一応
getHeighestY
みたいなメソッドに
HeightMap.RESOURCE_OVERWORLD_FOOBAR
渡すとレイヤごと高度を取れる(はず)

@sysnote8main sysnote8main self-assigned this Mar 20, 2026
@tksimeji
Copy link
Copy Markdown
Member

詳しく挙動を検証できていませんが,Back to islandボタンが反応しないケースがありそう

@tksimeji
Copy link
Copy Markdown
Member

資源ワールド側でベッドを使用してスポーン地点をsetしてもポータルの出口地点が変わっていなさそう?

@tksimeji
Copy link
Copy Markdown
Member

とりあえずver/1.21.11にrebase

@tksimeji
Copy link
Copy Markdown
Member

ResourceYProviderはカスタムHeightmapが正しく計算・取得できない問題に対する対処療法なのでnet.azisaba.vanilife.server.resource.*の生成コードそのものを調査する必要アリ

@sysnote8main
Copy link
Copy Markdown
Author

挙動テスト中...

)
context.lifecycleManager.registerEventHandler(
LifecycleEvents.TAGS.postFlatten(RegistryKey.DIALOG).newHandler { event ->
PortalDialog.registerTag(event)
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここで登録してる

RegistryEvents.DIALOG.compose().newHandler(PortalDialogs::bootstrap)
)
context.lifecycleManager.registerEventHandler(
LifecycleEvents.TAGS.postFlatten(RegistryKey.DIALOG).newHandler(PortalDialogTags::bootstrap)
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここでも登録してる

@sysnote8main sysnote8main merged commit fef07f3 into ver/1.21.11 Mar 22, 2026
@sysnote8main sysnote8main deleted the feature/portal branch March 22, 2026 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants