Skip to content

Feat/adding product details view#36

Merged
heliomar-pena merged 10 commits intodevfrom
feat/adding-product-details-view
Jun 4, 2022
Merged

Feat/adding product details view#36
heliomar-pena merged 10 commits intodevfrom
feat/adding-product-details-view

Conversation

@heliomar-pena
Copy link
Contributor

@heliomar-pena heliomar-pena commented May 31, 2022

Explanation

I've added the details product view, this PR solves the most of tasks of this story: #21

- [x] As a member, I want to see the name of the product.
- [x] As a member, I want to know the price of the product.
- [x] As a member, I would like to see a description of the product.
- [x] As a member, I would like to see an image alluding to the product.
- [x] As a member, I would like to have the option to go back from the product view.

Except by

- [ ] As a member, I would need to be able to add the product to a shopping cart.

Since the shopping cart is not developed yet

Summary

  • Added Product Details Styles
  • Integrated with the DB
  • Linked pages Provider Details with Product Details

Dependencies

This is in draft since need to be merged this PR first

Screenshots

image

How to test

  1. Go to https://deploy-preview-36--did-app.netlify.app/
  2. Go to the slug providers/a5528fa5-ffd9-4943-89fe-1a06b4a6a08e (or click here)
  3. Select a Product
  4. Test the features

@heliomar-pena heliomar-pena self-assigned this May 31, 2022
@heliomar-pena heliomar-pena marked this pull request as draft May 31, 2022 00:07
@netlify
Copy link

netlify bot commented May 31, 2022

Deploy Preview for did-app ready!

Name Link
🔨 Latest commit 72acb25
🔍 Latest deploy log https://app.netlify.com/sites/did-app/deploys/629bdab9afe8830008432ca2
😎 Deploy Preview https://deploy-preview-36--did-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Israel-Laguan
Copy link

Israel-Laguan commented May 31, 2022

When trying netlify deploy, I notice the product card in the bottom menu is not tappable, would that be addressed later?

Please update reproduction steps with deploy preview link

Update: I checked and seems like the button on the bottom menu is not valid, likely old code? Can you check, and if needed remove not used code
Screenshot_20220530-194051_Chrome.jpg

@heliomar-pena
Copy link
Contributor Author

heliomar-pena commented Jun 3, 2022

When trying netlify deploy, I notice the product card in the bottom menu is not tappable, would that be addressed later?

Please update reproduction steps with deploy preview link

Update: I checked and seems like the button on the bottom menu is not valid, likely old code? Can you check, and if needed remove not used code

@Israel-Laguan Thanks for the check, it's because now the product route needs a Product's ID, without ID can't open product routes. I will remove that route from navbar

@heliomar-pena heliomar-pena marked this pull request as ready for review June 3, 2022 04:21
Copy link

@e-azocar e-azocar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok, only one comment

@heliomar-pena heliomar-pena merged commit f69d53d into dev Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants