Conversation
GrKnght
reviewed
Dec 19, 2024
| super.onViewCreated(view, savedInstanceState) | ||
| questionText = view.findViewById(R.id.questionText) | ||
| radioGroup = view.findViewById(R.id.radioGroup) | ||
| radioButton1 = view.findViewById(R.id.radioButton1) |
There was a problem hiding this comment.
При такой реализации, если ответов на вопросы будет, например, больше 10, все они не влезут и не будут скроллиться. Было бы лучше реализовать это через ресайкл вью
GrKnght
reviewed
Dec 19, 2024
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
| setContentView(R.layout.activity_main) | ||
|
|
There was a problem hiding this comment.
У вас активити выступает как основной экран. По-хорошему, нужно реализовывать все через фрагменты
GrKnght
reviewed
Dec 19, 2024
|
|
||
| class MainActivity : AppCompatActivity() { | ||
|
|
||
| private lateinit var viewPager: ViewPager2 |
There was a problem hiding this comment.
Старайтесь избегать использования lateinit вместе с вьюшками - приводит к утечкам памяти
GrKnght
reviewed
Dec 19, 2024
GrKnght
left a comment
GrKnght
left a comment
There was a problem hiding this comment.
Работа проверена. Используете активити, а не фрагмент в качестве основного экрана
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://disk.yandex.ru/client/disk/Андроид