chore: begin typing note data provider #13702
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial attempt at trying to make these more readable. The technique can be trivially extended to MultiMap, but first I wanted to see how far I could take it before going all-in - for this reason I only used it in the note data provider.
It'd be very nice to also do something similar for keys, albeit in such a way where we accept anything that can be converted into a string as a key. It'd let us use
AztecAddress,Fr, etc. as types, helping make sense of the types and removing a lot oftoStringcalls that make the code hard to read and easy to misuse. However there'sK extends Keyconstraints all over the place, so doing this might not be trivial. I gave up after some brief exploration.