feat: evaluate all public input columns during verification of AVM #13779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Author
|
Goblin recursion test passes (33s), but standard recursion test fails with this msg (after 230s) |
dbanks12
force-pushed
the
db/tracegen-pis
branch
from
ec21154 to
cfdcc65
Compare
dbanks12
force-pushed
the
db/all-pi-columnns-evaled-verification
branch
from
4781951 to
c5d512c
Compare
dbanks12
force-pushed
the
db/tracegen-pis
branch
from
cfdcc65 to
25e49a3
Compare
dbanks12
force-pushed
the
db/all-pi-columnns-evaled-verification
branch
from
c5d512c to
2dcc984
Compare
dbanks12
force-pushed
the
db/tracegen-pis
branch
from
25e49a3 to
e1d8ce7
Compare
dbanks12
force-pushed
the
db/all-pi-columnns-evaled-verification
branch
from
2dcc984 to
1b2eda6
Compare
dbanks12
force-pushed
the
db/tracegen-pis
branch
from
e1d8ce7 to
f2f74bb
Compare
dbanks12
force-pushed
the
db/all-pi-columnns-evaled-verification
branch
from
1b2eda6 to
cc12f9d
Compare
dbanks12
force-pushed
the
db/all-pi-columnns-evaled-verification
branch
from
cc12f9d to
3a6dff9
Compare
dbanks12
force-pushed
the
db/all-pi-columnns-evaled-verification
branch
from
3a6dff9 to
8a7d5be
Compare
dbanks12
force-pushed
the
db/all-pi-columnns-evaled-verification
branch
from
8a7d5be to
8c70c82
Compare
dbanks12
force-pushed
the
db/all-pi-columnns-evaled-verification
branch
from
8c70c82 to
4f0d200
Compare
dbanks12
force-pushed
the
db/all-pi-columnns-evaled-verification
branch
from
4f0d200 to
96a6931
Compare
dbanks12
force-pushed
the
db/all-pi-columnns-evaled-verification
branch
from
96a6931 to
e45b6dd
Compare
jeanmon
approved these changes
May 7, 2025
Contributor
jeanmon
left a comment
jeanmon
left a comment
There was a problem hiding this comment.
LGTM. Have a look at comments before merging though.
barretenberg/cpp/src/barretenberg/vm2/constraining/recursion/recursive_verifier.cpp
Show resolved
Hide resolved
barretenberg/cpp/src/barretenberg/vm2/constraining/verifier.cpp
Outdated
Show resolved
Hide resolved
|
|
||
| function foreignCallHandler(): Promise<ForeignCallOutput[]> { | ||
| throw new Error('Unexpected foreign call'); | ||
| function foreignCallHandler(name: string, args: ForeignCallInput[]): Promise<ForeignCallOutput[]> { |
Contributor
There was a problem hiding this comment.
Isn't stgh unrelated to the public inputs PR? Some leftover of debuglogs work?
Contributor
Author
There was a problem hiding this comment.
This adds support in mock / ivc-integration tests for calls in noir to debug_log*. Probably good to have here for future debugging.
dbanks12
force-pushed
the
db/all-pi-columnns-evaled-verification
branch
from
e45b6dd to
665604d
Compare
dbanks12
force-pushed
the
db/tracegen-pis
branch
2 times, most recently
from
dd9cabb to
0cf5ba4
Compare
dbanks12
force-pushed
the
db/all-pi-columnns-evaled-verification
branch
3 times, most recently
from
06e2bc8 to
0e7c433
Compare
dbanks12
force-pushed
the
db/all-pi-columnns-evaled-verification
branch
from
0e7c433 to
3dfa5ae
Compare
dbanks12
force-pushed
the
db/all-pi-columnns-evaled-verification
branch
from
3dfa5ae to
36b649c
Compare
dbanks12
force-pushed
the
db/all-pi-columnns-evaled-verification
branch
from
36b649c to
7c49a2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read contributing guidelines and remove this line.