Skip to content

Conversation

@benesjan
Copy link
Contributor

@benesjan benesjan commented Jul 28, 2025

Needed to do the following to resolve remaining visibility issue that currently blocks Noir sync:

  • Exposed a few modules from Aztec.nr as in the it's prohibited to access private modules.
  • Updated https://github.com/noir-lang/sha256 dependency as an older version had a visibility issue present.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@benesjan benesjan marked this pull request as ready for review July 28, 2025 08:22
@benesjan benesjan force-pushed the 07-28-fix_addressing_remaining_visibility_warnings branch from 6163d7b to a2dad45 Compare July 28, 2025 08:51
@benesjan benesjan requested a review from LeilaWang as a code owner July 28, 2025 08:52
@benesjan benesjan requested a review from Thunkar July 28, 2025 09:12
@benesjan benesjan enabled auto-merge July 28, 2025 09:12
@benesjan benesjan requested a review from nventuro July 28, 2025 10:25
@iAmMichaelConnor
Copy link
Contributor

I'm suprised they're not all pub. How do external folks make use of all of the structs and functions of aztec-nr if they're not all pub?

@benesjan benesjan added this pull request to the merge queue Jul 28, 2025
Merged via the queue into next with commit dc0c456 Jul 28, 2025
8 checks passed
@benesjan benesjan deleted the 07-28-fix_addressing_remaining_visibility_warnings branch July 28, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants