refactor: pythonise benchmark file generation#16029
Merged
Conversation
LHerskind
force-pushed
the
lh/tmnt-83-ingition-specific-benchmark
branch
from
5c9a22d to
cb5b552
Compare
LHerskind
force-pushed
the
lh/tmnt-83-ingition-specific-benchmark
branch
from
cb5b552 to
2a8614d
Compare
just-mitch
reviewed
Jul 28, 2025
| submit_proof_gas = config_data["submitEpochRootProof"].get("mean", 0) | ||
|
|
||
| # Calculate gas cost per second | ||
| total_epoch_gas = setup_epoch_gas + (propose_gas * epoch_duration) + submit_proof_gas |
Collaborator
There was a problem hiding this comment.
I read this as "total gas demanded by the protocol in an epoch" so I think we should multiply the submit_proof_gas by however many proofs will be subsidized.
Contributor
Author
There was a problem hiding this comment.
Sure, can alter that and put it as a variable. Related to that, it is likely some config we need to outline very directly how to alter.
just-mitch
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Altering the solidity benchmark file generation such that it is simpler to follow by not using
awkbut also making it a bit more elaborate to produce results for both ignition and alpha configurations in one go, making it simpler to get an idea of the "real" costs and not "the costs that the benchmark config have". The configuration is added to the markdown file, and the gas per second is also added to both benchmark and markdown doc.I tried to group the benchmarks into different configs so they hopefully are easier to jump around in at the benchmark page.
Updated the l1 metadata loaded in benchmark slightly to better accomedate longer l2 block times without running out of data.