feat(avm)!: enable optimized poseidon2 rels #16467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
IlyasRidhuan
force-pushed
the
ir/08-15-perf_avm_hand_tune_poseidon2_perm
branch
from
ef0e50d to
2766d06
Compare
IlyasRidhuan
force-pushed
the
ir/08-19-feat_avm_enable_optimized_poseidon2_rels
branch
2 times, most recently
from
0b94d25 to
303c053
Compare
IlyasRidhuan
commented
Aug 21, 2025
| let used_alias_defs_in_skippable = alias_expressions_in_order | ||
| .iter() | ||
| .filter(|(name, _, _)| skippable_if.as_ref().map(|id| id.identity == *name).unwrap_or(false)) | ||
| .filter(|(name, _, _)| { |
Contributor
Author
There was a problem hiding this comment.
weird - formatting changes?
IlyasRidhuan
commented
Aug 21, 2025
| "relation_impls.hpp", | ||
| std::str::from_utf8(include_bytes!("../templates/relation_impls.hpp.hbs")).unwrap(), | ||
| ).unwrap(); | ||
| handlebars |
IlyasRidhuan
commented
Aug 21, 2025
| ) | ||
| .unwrap(); | ||
|
|
||
| let optimized_relations = self.get_optimized_relations_file_names(); |
Contributor
Author
There was a problem hiding this comment.
This is new though
IlyasRidhuan
force-pushed
the
ir/08-19-feat_avm_enable_optimized_poseidon2_rels
branch
2 times, most recently
from
180f999 to
3a349c6
Compare
fcarreiro
approved these changes
Aug 21, 2025
Base automatically changed from
ir/08-15-perf_avm_hand_tune_poseidon2_perm
to
next
August 21, 2025 14:44
IlyasRidhuan
force-pushed
the
ir/08-19-feat_avm_enable_optimized_poseidon2_rels
branch
from
3a349c6 to
905e019
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
IlyasRidhuan
deleted the
ir/08-19-feat_avm_enable_optimized_poseidon2_rels
branch
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates bb-pilcom to change the generated files.
Now the choice of whether to use
generated/poseidon2_permoroptimized/poseidon2_permcan be made viabb-pilcomthrough the use offeature-flags(seeREADME.md).I could not convince CMake to ignore building
generated/poseidon2_permfile even if it wasn't included in any other files, so the solution for now was also to not generate theposeidon2_permfile when using the optimized one.This does mean that the generated folder should be deleted if switching between from generated to optimized to minimise wasted compiling time (this is already supported by the
-yflag in the cli)