chore: Store sentinel proven performance for a longer time #16955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support `slashInactivityConsecutiveEpochThreshold` greater than 1. To avoid also storing a lot of raw stats, this PR also decouples the history length and proven performance length stored.
PhilWindle
reviewed
Sep 12, 2025
|
|
||
| // This should be sorted by epoch, but just in case. | ||
| // Since we keep the size small, this is not a big deal. | ||
| currentPerformance.sort((a, b) => Number(a.epoch - b.epoch)); |
Collaborator
There was a problem hiding this comment.
I'm not overly familiar with this area of code. But does this PR invalidate the assumption of // Since we keep the size small, this is not a big deal.?
Contributor
Author
There was a problem hiding this comment.
It kinda does, that's why I added the unit test with 2k entries. It runs fast enough, nothing to worry about.
PhilWindle
approved these changes
Sep 12, 2025
spalladino
added a commit
that referenced
this pull request
Sep 12, 2025
To support `slashInactivityConsecutiveEpochThreshold` greater than 1. To avoid also storing a lot of raw stats, this PR also decouples the history length and proven performance length stored.
spalladino
added a commit
that referenced
this pull request
Sep 12, 2025
To support `slashInactivityConsecutiveEpochThreshold` greater than 1. To avoid also storing a lot of raw stats, this PR also decouples the history length and proven performance length stored.
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support
slashInactivityConsecutiveEpochThresholdgreater than 1.To avoid also storing a lot of raw stats, this PR also decouples the history length and proven performance length stored.