feat: merge-train/avm #16991
Merged
feat: merge-train/avm #16991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
With 16 cores for the avm trace (2^21), the time goes from ca. 80 ms to 37 ms. For a trace of size 2^24, timing goes from 600 ms to 280ms. Relevant issue [#864](AztecProtocol/barretenberg#864)
jeanmon
requested review from
IlyasRidhuan,
fcarreiro and
jeanmon
as code owners
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
PR changes the approach for handling protocol contracts in the AVM. Introduces a `ProtocolContractSetInterface` that manages the static (per rollup deployment) set of protocol contract's derived addresses. The current implementation of this set is as an indexed merkle tree - although hopefully we are able to migrate to a simpler (non-indexed tree) structure. When retrieving the derived address for a protocol contract, we also produce a merkle membership path that is checked against the L1 public contracts tree root (currently unconstrained). This will eventually be included in the public inputs of the AVM. There is a new corresponding subtrace for the protocol contracts derived address retrieval The map of canonical address to derived address is hinted via TS as part of `AvmExecutionHints`
IlyasRidhuan
requested review from
LeilaWang,
Maddiaa0,
dbanks12 and
sirasistant
as code owners
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore(avm): always print bulk bench metrics
chore: betas optimization - 2^d multiplications (#16963)
docs: Add migration notes for gas costs (#16925)
feat(avm)!: protocol contracts (#16949)
END_COMMIT_OVERRIDE