feat: Allow simulateUtility batching, better BatchCall#17938
Merged
Conversation
We have to rethink and probably rename `BatchCall`, but he functionality implemented by this PR is sorely needed: - Allow multiple utilities to be sent to the wallet as a batch, instead of relying on `Promise.all` and `BatchCall` - Do not allow `BatchCall` to create an empty transaction along the utilities if no private/public calls are provided - Add tests Co-authored-by: thunkar <gregojquiros@gmail.com>
b673e95 to
feb335f
Compare
benesjan
approved these changes
Oct 24, 2025
Contributor
benesjan
left a comment
There was a problem hiding this comment.
As discussed in DMs approving this to unblock the demo while keeping in mind that the BatchCall will be refactored and the naming eventually fixed.
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have to rethink and probably rename
BatchCall, but he functionality implemented by this PR is sorely needed:Promise.allandBatchCallBatchCallto create an empty transaction along the utilities if no private/public calls are provided