chore: keccak stdlib cleanup #19169
Merged
chore: keccak stdlib cleanup #19169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nishatkoti
commented
Dec 20, 2025
nishatkoti
commented
- Add constraint tests in ACIR
- Update literal numbers to named constants
- Clean up the keccak and relevant lookup files
- Update stdlib tests to check correctness of lookup output in addition to the circuit validity
ledwards2225
approved these changes
Dec 22, 2025
| * | ||
| * @param key (first element = table input. Second element is unused as this lookup does not have 2 keys per value) | ||
| * @return std::array<bb::fr, 2> table output (normalized input and normalized input / 11^TABLE_BITS - 1) | ||
| * @return std::array<bb::fr, 2> table output {normalized, 0} |
Contributor
There was a problem hiding this comment.
I assume the 0 here is unused? if so you could specify that in the comment for clarity
nishatkoti
force-pushed
the
nk/keccak-second-pass
branch
from
b4a1a56 to
6e320e7
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 23, 2025
BEGIN_COMMIT_OVERRIDE chore: Goblin AVM verifier audit - part 1 (#19091) chore: (PCS audit) added readmes and documentation for each component (#19092) chore: fix the wrong vm2 recursion vk (#19189) fix the pinned vk hash chore: unified chonk verifier (#19145) chore: keccak stdlib cleanup (#19169) END_COMMIT_OVERRIDE
github-actions bot
pushed a commit
that referenced
this pull request
Dec 23, 2025
- Add constraint tests in ACIR - Update literal numbers to named constants - Clean up the keccak and relevant lookup files - Update stdlib tests to check correctness of lookup output in addition to the circuit validity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.