refactor: passing anchor block header instead of block store #20043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mverzilli
approved these changes
Jan 29, 2026
Contributor
mverzilli
left a comment
mverzilli
left a comment
There was a problem hiding this comment.
lovely! just the one comment
benesjan
force-pushed
the
01-29-refactor_passing_anchor_block_header_instead_of_block_store
branch
from
ef6a64e to
ea3ec69
Compare
Discussed in DMs with @mverzilli that it doesn't make sense to pass around anchor block store to the execution oracles given that the anchor block needs to be fixed during the duration of the execution. Hence in this PR I am dropping it from the relevant constructors and instead just an anchor block header is passed around. Related to this also makes sense to make the `AnchorBlockStore` work solely in memory and not with persistent db as we always first sync the block header from node before simulation. This will be tackled in a followup PR.
AztecBot
force-pushed
the
01-29-refactor_passing_anchor_block_header_instead_of_block_store
branch
from
783c040 to
0e79d93
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
benesjan
deleted the
01-29-refactor_passing_anchor_block_header_instead_of_block_store
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in DMs with @mverzilli that it doesn't make sense to pass around anchor block store to the execution oracles given that the anchor block needs to be fixed during the duration of the execution. Hence in this PR I am dropping it from the relevant constructors and instead just an anchor block header is passed around.
Related to this also makes sense to make the
AnchorBlockStorework solely in memory and not with persistent db as we always first sync the block header from node before simulation. This will be tackled in a followup PR.