fix(ci): build noir packages before yarn-project in nightly docs workflow #20053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critesjosh
force-pushed
the
josh/ecodr-725-fix-nightly-docs-releases
branch
from
28ab1a7 to
9b0eca7
Compare
sklppy88
approved these changes
Jan 29, 2026
…flow ## Summary - Fixes the nightly-docs-release workflow which has been failing since Jan 27 - Fixes the same issue in release-please workflow (preventive) ## Problem PR #19284 added a "Build aztec CLI" step that runs `yarn-project/bootstrap.sh`, but this fails because yarn-project has portal dependencies on `noir/packages/` (e.g., `@aztec/noir-acvm_js`). This directory is only created by `noir/bootstrap.sh` and is not tracked in git. **Error:** ``` Error: @aztec/noir-acvm_js@portal:../noir/packages/acvm_js: Manifest not found ``` ## Solution Add a step to initialize the noir submodule and build the JS packages before running yarn-project bootstrap in both workflows. ## Test plan - [ ] Trigger the nightly docs workflow manually and verify it succeeds 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Josh Crites <jc@joshcrites.com>
AztecBot
force-pushed
the
josh/ecodr-725-fix-nightly-docs-releases
branch
from
9b0eca7 to
ccf9c1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
PR #19284 added a "Build aztec CLI" step that runs
yarn-project/bootstrap.sh, but this fails because yarn-project has portal dependencies onnoir/packages/(e.g.,@aztec/noir-acvm_js). This directory is only created bynoir/bootstrap.shand is not tracked in git.Error:
Solution
Add a step to initialize the noir submodule and build the JS packages before running yarn-project bootstrap in both workflows.
Test plan
🤖 Generated with Claude Code