fix: flaky deadline test in BatchTxRequester#20068
Merged
Conversation
PhilWindle
approved these changes
Jan 30, 2026
fix(p2p): fix flaky deadline test in BatchTxRequester
mralj
force-pushed
the
mralj/fix/batch_tx_req_deflake
branch
from
2f8f7fe to
db5cc9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes race condition in "should stop requesting when deadline is reached" test.
The test mixed a fake clock with real-time
sleep(), causing flakiness in CI where the sleep could oversleep and allow extra batches to be sent before the deadline was triggered.Fix: Advance the fake clock immediately after the first request starts to ensure deterministic behavior.