Merged
Conversation
This PR performs the following changes (kudo to @fcarreiro for suggesting this): - precomputed.clk is non-zero only on the active portion of the precomputed subtrace - Introduce a clk column in execution sub-trace (counter on active rows). For each execution dispatching lookup using precomputed.clk, we replace precomputed.clk by execution.clk. - Rename precomputed.clk by precomputed.idx Performance improvements * PCS: goes from `3s` to ~`1.3s` on 32 cores. * For bulk this is a small improvement. * But for token transfers it is a 25%+ improvement.
AztecBot
requested review from
IlyasRidhuan,
Maddiaa0,
fcarreiro and
jeanmon
as code owners
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
1 similar comment
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat(avm)!: smaller precomputed trace (#20144)
END_COMMIT_OVERRIDE