fix!: change protocol contracts deployer to be the contract address#20396
Merged
PhilWindle merged 1 commit intomerge-train/spartanfrom Feb 11, 2026
Merged
fix!: change protocol contracts deployer to be the contract address#20396PhilWindle merged 1 commit intomerge-train/spartanfrom
PhilWindle merged 1 commit intomerge-train/spartanfrom
Conversation
alexghr
commented
Feb 11, 2026
| // TODO(@spalladino): This computes the contract class from the artifact twice. | ||
| const contractClass = await getContractClassFromArtifact(artifact); | ||
| const instance = await getContractInstanceFromInstantiationParams(artifact, { salt }); | ||
| const instance = await getContractInstanceFromInstantiationParams(artifact, { salt, deployer: address }); |
Contributor
Author
There was a problem hiding this comment.
this will be the low address, not the instance derived address
alexghr
force-pushed
the
ag/protocol-contracts-deployer
branch
from
8f3a971 to
2c21cbf
Compare
IlyasRidhuan
approved these changes
Feb 11, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 12, 2026
BEGIN_COMMIT_OVERRIDE chore: Should fix proving benchmarks by reducing committee lag (#20381) chore: standalone forge broadcast wrapper with retry, timeout, and anvil detection (#19824) chore: benchmark tx val (#20227) fix: cloudflare terraform API (#20387) fix: HA e2e test order & retries (#20383) fix: incorporate forge broadcast review feedback (#20390) refactor(p2p): rewrite FileStoreTxCollection with retry, backoff, and shared worker pool (#20317) chore(ci): run ci job on draft PRs (#20395) feat(bot): allow anchoring txs to proposed chain (#20392) feat(p2p): slot-based soft deletion for TxPoolV2 (#20388) chore: add setup-container script (#20309) feat: build aztec-prover-agent with baked-in CRS (#20391) fix!: change protocol contracts deployer to be the contract address (#20396) feat(p2p): enforce minimum tx pool age for block building (#20384) refactor(sentinel): update validator statuses to checkpoint-based naming (#20372) chore: log tx hash (#20413) chore: update l1 fee analysis to measure blob count in L1 blocks (#20414) chore: set up tx file store in next-net (#20418) chore(ci): gate draft PRs from CI, allow override with ci-draft label (#20426) fix: stabilize writing_an_account_contract.test.ts (#20420) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.