Skip to content

chore!: pre-audit of avm update_check.pil#20783

Merged
dbanks12 merged 11 commits into
merge-train/avmfrom
db/update-check-audit
Mar 3, 2026
Merged

chore!: pre-audit of avm update_check.pil#20783
dbanks12 merged 11 commits into
merge-train/avmfrom
db/update-check-audit

Conversation

@dbanks12

@dbanks12 dbanks12 commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

pre-audit of avm update_check.pil. No vulnerabilities found.
Linear issue: https://linear.app/aztec-labs/issue/AVM-58/bytecode-update-checkpil

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Comment on lines 135 to 145
sel {
update_hash,
deployer_protocol_contract_address,
delayed_public_mutable_hash_slot,
update_hash,
public_data_tree_root
} in public_data_check.sel {
public_data_check.value,
public_data_check.address,
public_data_check.slot,
public_data_check.value,
public_data_check.root
};

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to match order in "USAGE" section of public data check PIL

@dbanks12 dbanks12 force-pushed the db/update-check-audit branch 6 times, most recently from 0e75287 to 5830c5b Compare February 25, 2026 17:16
@dbanks12 dbanks12 marked this pull request as ready for review February 25, 2026 19:40
@dbanks12 dbanks12 requested review from sirasistant and removed request for IlyasRidhuan, Maddiaa0, fcarreiro and jeanmon February 25, 2026 19:41
@dbanks12 dbanks12 changed the title chore: pre-audit of avm update_check.pil chore!: pre-audit of avm update_check.pil Feb 25, 2026
Comment thread barretenberg/cpp/src/barretenberg/vm2/simulation/gadgets/update_check.cpp Outdated
Comment thread barretenberg/cpp/src/barretenberg/vm2/tracegen/update_check_trace.cpp Outdated
@dbanks12 dbanks12 force-pushed the db/update-check-audit branch from aea9cfa to 8b33bd2 Compare February 27, 2026 15:39
@dbanks12 dbanks12 requested a review from sirasistant February 27, 2026 15:47
@dbanks12 dbanks12 force-pushed the db/update-check-audit branch from 8b33bd2 to ae3596f Compare February 27, 2026 15:48
@dbanks12 dbanks12 force-pushed the db/update-check-audit branch from ae3596f to d1ac7e5 Compare March 2, 2026 21:01

@sirasistant sirasistant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dbanks12 dbanks12 merged commit 24c0e34 into merge-train/avm Mar 3, 2026
14 of 15 checks passed
@dbanks12 dbanks12 deleted the db/update-check-audit branch March 3, 2026 14:12
@AztecBot AztecBot mentioned this pull request Mar 3, 2026
github-merge-queue Bot pushed a commit that referenced this pull request Mar 4, 2026
BEGIN_COMMIT_OVERRIDE
chore!: pre-audit of avm update_check.pil (#20783)
END_COMMIT_OVERRIDE
johnathan79717 pushed a commit that referenced this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants