Skip to content

fix: release#20932

Merged
ludamad merged 1 commit intonextfrom
claudebox/c032c3652134b179-1
Feb 27, 2026
Merged

fix: release#20932
ludamad merged 1 commit intonextfrom
claudebox/c032c3652134b179-1

Conversation

@AztecBot
Copy link
Collaborator

@AztecBot AztecBot commented Feb 27, 2026

Summary

Makefile: The bb-cpp-cross-arm64-linux target depended on avm-transpiler-native instead of a cross-compiled arm64-linux avm-transpiler, so the cross-compiled libavm_transpiler.a was never built. Adds the missing avm-transpiler-cross-arm64-linux target and fixes the dependency.

barretenberg-rs release: The release function would error out if generated Rust bindings (api.rs, generated_types.rs) weren't present, even though it's trivial to generate them. Now generates them on-the-fly instead of failing.

Follows up on #20814 which added avm-transpiler arm64-linux support.

@AztecBot AztecBot added the claudebox Owned by claudebox. it can push to this PR. label Feb 27, 2026
@ludamad ludamad changed the title fix: make cross_copy a no-op on arm64 instead of erroring fix: release Feb 27, 2026
@ludamad ludamad marked this pull request as ready for review February 27, 2026 02:59
@ludamad ludamad added ci-release-pr and removed ci-release-pr claudebox Owned by claudebox. it can push to this PR. labels Feb 27, 2026
Summary

Makefile: The bb-cpp-cross-arm64-linux target depended on avm-transpiler-native instead of a cross-compiled arm64-linux avm-transpiler, so the cross-compiled libavm_transpiler.a was never built. Adds the missing avm-transpiler-cross-arm64-linux target and fixes the dependency.

barretenberg-rs release: The release function would error out if generated Rust bindings (api.rs, generated_types.rs) weren't present, even though it's trivial to generate them. Now generates them on-the-fly instead of failing.

Follows up on #20814 which added avm-transpiler arm64-linux support.
@AztecBot AztecBot force-pushed the claudebox/c032c3652134b179-1 branch from ff63327 to 00f2f2b Compare February 27, 2026 13:54
@ludamad ludamad added this pull request to the merge queue Feb 27, 2026
Merged via the queue into next with commit aab284b Feb 27, 2026
18 checks passed
@ludamad ludamad deleted the claudebox/c032c3652134b179-1 branch February 27, 2026 14:23
AztecBot added a commit that referenced this pull request Mar 3, 2026
…20814, #20932)

Cherry-picks two fixes from next that enable the AVM transpiler for
linux/arm64 release builds:

- avm-transpiler/bootstrap.sh: add arm64-linux case to build_cross
- CMakePresets.json: wire AVM_TRANSPILER_LIB for zig-arm64-linux preset
- Makefile: add avm-transpiler-cross-arm64-linux target, fix dependency
- barretenberg-rs: generate bindings on-the-fly in release function
- copy_cross.sh: relax arch check for release context

Fixes #20793
AztecBot added a commit that referenced this pull request Mar 4, 2026
…20932)

## Summary

Backports two fixes from `next` that enable the AVM transpiler for `linux/arm64` release builds, resolving [#20793](#20793) — `aztec compile` fails with "AVM Transpiler is not enabled" on `linux/arm64`.

**Cherry-picked from:**
- #20814 — added `arm64-linux` cross-compile to `avm-transpiler/bootstrap.sh` + wired `AVM_TRANSPILER_LIB` in `CMakePresets.json`
- #20932 — fixed Makefile dependency (`bb-cpp-cross-arm64-linux` was depending on `avm-transpiler-native` instead of `avm-transpiler-cross-arm64-linux`), plus `barretenberg-rs` release fix

**Root cause:** The `zig-arm64-linux` CMake preset was missing `AVM_TRANSPILER_LIB`, and `avm-transpiler/bootstrap.sh` had no `arm64-linux` case in `build_cross`. The arm64-linux bb binary was compiled without `ENABLE_AVM_TRANSPILER`.

**Changes:**
- `avm-transpiler/bootstrap.sh` — add `arm64-linux` case to `build_cross`
- `barretenberg/cpp/CMakePresets.json` — wire `AVM_TRANSPILER_LIB` for `zig-arm64-linux` preset
- `Makefile` — add `avm-transpiler-cross-arm64-linux` target, fix `bb-cpp-cross-arm64-linux` dependency
- `barretenberg/rust/bootstrap.sh` — add `release` function with on-the-fly binding generation
- `barretenberg/ts/scripts/copy_cross.sh` — relax arch check for release context

**Conflict resolution:** `barretenberg/rust/bootstrap.sh` had a minor conflict — the `release` function didn't exist on v4. Resolved by accepting the full function.

## Test plan
- [x] Native avm-transpiler build succeeds
- [x] Makefile targets verified: `avm-transpiler-cross-arm64-linux`, `bb-cpp-cross-arm64-linux` dependency corrected
- [x] CMake preset verified: `zig-arm64-linux` has `AVM_TRANSPILER_LIB` pointing to correct cross-compiled path
- [ ] Full cross-compilation validated in release CI

Closes #20793

ClaudeBox log: http://ci.aztec-labs.com/596d4a62f30fd2f0-2
ludamad pushed a commit that referenced this pull request Mar 12, 2026
…20932)

Backports two fixes from `next` that enable the AVM transpiler for `linux/arm64` release builds, resolving [#20793](#20793) — `aztec compile` fails with "AVM Transpiler is not enabled" on `linux/arm64`.

**Cherry-picked from:**
- #20814 — added `arm64-linux` cross-compile to `avm-transpiler/bootstrap.sh` + wired `AVM_TRANSPILER_LIB` in `CMakePresets.json`
- #20932 — fixed Makefile dependency (`bb-cpp-cross-arm64-linux` was depending on `avm-transpiler-native` instead of `avm-transpiler-cross-arm64-linux`), plus `barretenberg-rs` release fix

**Root cause:** The `zig-arm64-linux` CMake preset was missing `AVM_TRANSPILER_LIB`, and `avm-transpiler/bootstrap.sh` had no `arm64-linux` case in `build_cross`. The arm64-linux bb binary was compiled without `ENABLE_AVM_TRANSPILER`.

**Changes:**
- `avm-transpiler/bootstrap.sh` — add `arm64-linux` case to `build_cross`
- `barretenberg/cpp/CMakePresets.json` — wire `AVM_TRANSPILER_LIB` for `zig-arm64-linux` preset
- `Makefile` — add `avm-transpiler-cross-arm64-linux` target, fix `bb-cpp-cross-arm64-linux` dependency
- `barretenberg/rust/bootstrap.sh` — add `release` function with on-the-fly binding generation
- `barretenberg/ts/scripts/copy_cross.sh` — relax arch check for release context

**Conflict resolution:** `barretenberg/rust/bootstrap.sh` had a minor conflict — the `release` function didn't exist on v4. Resolved by accepting the full function.

- [x] Native avm-transpiler build succeeds
- [x] Makefile targets verified: `avm-transpiler-cross-arm64-linux`, `bb-cpp-cross-arm64-linux` dependency corrected
- [x] CMake preset verified: `zig-arm64-linux` has `AVM_TRANSPILER_LIB` pointing to correct cross-compiled path
- [ ] Full cross-compilation validated in release CI

Closes #20793

ClaudeBox log: http://ci.aztec-labs.com/596d4a62f30fd2f0-2
ludamad pushed a commit that referenced this pull request Mar 12, 2026
…20932)

Backports two fixes from `next` that enable the AVM transpiler for `linux/arm64` release builds, resolving [#20793](#20793) — `aztec compile` fails with "AVM Transpiler is not enabled" on `linux/arm64`.

**Cherry-picked from:**
- #20814 — added `arm64-linux` cross-compile to `avm-transpiler/bootstrap.sh` + wired `AVM_TRANSPILER_LIB` in `CMakePresets.json`
- #20932 — fixed Makefile dependency (`bb-cpp-cross-arm64-linux` was depending on `avm-transpiler-native` instead of `avm-transpiler-cross-arm64-linux`), plus `barretenberg-rs` release fix

**Root cause:** The `zig-arm64-linux` CMake preset was missing `AVM_TRANSPILER_LIB`, and `avm-transpiler/bootstrap.sh` had no `arm64-linux` case in `build_cross`. The arm64-linux bb binary was compiled without `ENABLE_AVM_TRANSPILER`.

**Changes:**
- `avm-transpiler/bootstrap.sh` — add `arm64-linux` case to `build_cross`
- `barretenberg/cpp/CMakePresets.json` — wire `AVM_TRANSPILER_LIB` for `zig-arm64-linux` preset
- `Makefile` — add `avm-transpiler-cross-arm64-linux` target, fix `bb-cpp-cross-arm64-linux` dependency
- `barretenberg/rust/bootstrap.sh` — add `release` function with on-the-fly binding generation
- `barretenberg/ts/scripts/copy_cross.sh` — relax arch check for release context

**Conflict resolution:** `barretenberg/rust/bootstrap.sh` had a minor conflict — the `release` function didn't exist on v4. Resolved by accepting the full function.

- [x] Native avm-transpiler build succeeds
- [x] Makefile targets verified: `avm-transpiler-cross-arm64-linux`, `bb-cpp-cross-arm64-linux` dependency corrected
- [x] CMake preset verified: `zig-arm64-linux` has `AVM_TRANSPILER_LIB` pointing to correct cross-compiled path
- [ ] Full cross-compilation validated in release CI

Closes #20793

ClaudeBox log: http://ci.aztec-labs.com/596d4a62f30fd2f0-2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants