Conversation
alexghr
approved these changes
Feb 27, 2026
2 tasks
7b86788 to
ff63327
Compare
Summary Makefile: The bb-cpp-cross-arm64-linux target depended on avm-transpiler-native instead of a cross-compiled arm64-linux avm-transpiler, so the cross-compiled libavm_transpiler.a was never built. Adds the missing avm-transpiler-cross-arm64-linux target and fixes the dependency. barretenberg-rs release: The release function would error out if generated Rust bindings (api.rs, generated_types.rs) weren't present, even though it's trivial to generate them. Now generates them on-the-fly instead of failing. Follows up on #20814 which added avm-transpiler arm64-linux support.
ff63327 to
00f2f2b
Compare
AztecBot
added a commit
that referenced
this pull request
Mar 3, 2026
…20814, #20932) Cherry-picks two fixes from next that enable the AVM transpiler for linux/arm64 release builds: - avm-transpiler/bootstrap.sh: add arm64-linux case to build_cross - CMakePresets.json: wire AVM_TRANSPILER_LIB for zig-arm64-linux preset - Makefile: add avm-transpiler-cross-arm64-linux target, fix dependency - barretenberg-rs: generate bindings on-the-fly in release function - copy_cross.sh: relax arch check for release context Fixes #20793
AztecBot
added a commit
that referenced
this pull request
Mar 3, 2026
4 tasks
AztecBot
added a commit
that referenced
this pull request
Mar 4, 2026
…20932) ## Summary Backports two fixes from `next` that enable the AVM transpiler for `linux/arm64` release builds, resolving [#20793](#20793) — `aztec compile` fails with "AVM Transpiler is not enabled" on `linux/arm64`. **Cherry-picked from:** - #20814 — added `arm64-linux` cross-compile to `avm-transpiler/bootstrap.sh` + wired `AVM_TRANSPILER_LIB` in `CMakePresets.json` - #20932 — fixed Makefile dependency (`bb-cpp-cross-arm64-linux` was depending on `avm-transpiler-native` instead of `avm-transpiler-cross-arm64-linux`), plus `barretenberg-rs` release fix **Root cause:** The `zig-arm64-linux` CMake preset was missing `AVM_TRANSPILER_LIB`, and `avm-transpiler/bootstrap.sh` had no `arm64-linux` case in `build_cross`. The arm64-linux bb binary was compiled without `ENABLE_AVM_TRANSPILER`. **Changes:** - `avm-transpiler/bootstrap.sh` — add `arm64-linux` case to `build_cross` - `barretenberg/cpp/CMakePresets.json` — wire `AVM_TRANSPILER_LIB` for `zig-arm64-linux` preset - `Makefile` — add `avm-transpiler-cross-arm64-linux` target, fix `bb-cpp-cross-arm64-linux` dependency - `barretenberg/rust/bootstrap.sh` — add `release` function with on-the-fly binding generation - `barretenberg/ts/scripts/copy_cross.sh` — relax arch check for release context **Conflict resolution:** `barretenberg/rust/bootstrap.sh` had a minor conflict — the `release` function didn't exist on v4. Resolved by accepting the full function. ## Test plan - [x] Native avm-transpiler build succeeds - [x] Makefile targets verified: `avm-transpiler-cross-arm64-linux`, `bb-cpp-cross-arm64-linux` dependency corrected - [x] CMake preset verified: `zig-arm64-linux` has `AVM_TRANSPILER_LIB` pointing to correct cross-compiled path - [ ] Full cross-compilation validated in release CI Closes #20793 ClaudeBox log: http://ci.aztec-labs.com/596d4a62f30fd2f0-2
ludamad
pushed a commit
that referenced
this pull request
Mar 12, 2026
…20932) Backports two fixes from `next` that enable the AVM transpiler for `linux/arm64` release builds, resolving [#20793](#20793) — `aztec compile` fails with "AVM Transpiler is not enabled" on `linux/arm64`. **Cherry-picked from:** - #20814 — added `arm64-linux` cross-compile to `avm-transpiler/bootstrap.sh` + wired `AVM_TRANSPILER_LIB` in `CMakePresets.json` - #20932 — fixed Makefile dependency (`bb-cpp-cross-arm64-linux` was depending on `avm-transpiler-native` instead of `avm-transpiler-cross-arm64-linux`), plus `barretenberg-rs` release fix **Root cause:** The `zig-arm64-linux` CMake preset was missing `AVM_TRANSPILER_LIB`, and `avm-transpiler/bootstrap.sh` had no `arm64-linux` case in `build_cross`. The arm64-linux bb binary was compiled without `ENABLE_AVM_TRANSPILER`. **Changes:** - `avm-transpiler/bootstrap.sh` — add `arm64-linux` case to `build_cross` - `barretenberg/cpp/CMakePresets.json` — wire `AVM_TRANSPILER_LIB` for `zig-arm64-linux` preset - `Makefile` — add `avm-transpiler-cross-arm64-linux` target, fix `bb-cpp-cross-arm64-linux` dependency - `barretenberg/rust/bootstrap.sh` — add `release` function with on-the-fly binding generation - `barretenberg/ts/scripts/copy_cross.sh` — relax arch check for release context **Conflict resolution:** `barretenberg/rust/bootstrap.sh` had a minor conflict — the `release` function didn't exist on v4. Resolved by accepting the full function. - [x] Native avm-transpiler build succeeds - [x] Makefile targets verified: `avm-transpiler-cross-arm64-linux`, `bb-cpp-cross-arm64-linux` dependency corrected - [x] CMake preset verified: `zig-arm64-linux` has `AVM_TRANSPILER_LIB` pointing to correct cross-compiled path - [ ] Full cross-compilation validated in release CI Closes #20793 ClaudeBox log: http://ci.aztec-labs.com/596d4a62f30fd2f0-2
ludamad
pushed a commit
that referenced
this pull request
Mar 12, 2026
…20932) Backports two fixes from `next` that enable the AVM transpiler for `linux/arm64` release builds, resolving [#20793](#20793) — `aztec compile` fails with "AVM Transpiler is not enabled" on `linux/arm64`. **Cherry-picked from:** - #20814 — added `arm64-linux` cross-compile to `avm-transpiler/bootstrap.sh` + wired `AVM_TRANSPILER_LIB` in `CMakePresets.json` - #20932 — fixed Makefile dependency (`bb-cpp-cross-arm64-linux` was depending on `avm-transpiler-native` instead of `avm-transpiler-cross-arm64-linux`), plus `barretenberg-rs` release fix **Root cause:** The `zig-arm64-linux` CMake preset was missing `AVM_TRANSPILER_LIB`, and `avm-transpiler/bootstrap.sh` had no `arm64-linux` case in `build_cross`. The arm64-linux bb binary was compiled without `ENABLE_AVM_TRANSPILER`. **Changes:** - `avm-transpiler/bootstrap.sh` — add `arm64-linux` case to `build_cross` - `barretenberg/cpp/CMakePresets.json` — wire `AVM_TRANSPILER_LIB` for `zig-arm64-linux` preset - `Makefile` — add `avm-transpiler-cross-arm64-linux` target, fix `bb-cpp-cross-arm64-linux` dependency - `barretenberg/rust/bootstrap.sh` — add `release` function with on-the-fly binding generation - `barretenberg/ts/scripts/copy_cross.sh` — relax arch check for release context **Conflict resolution:** `barretenberg/rust/bootstrap.sh` had a minor conflict — the `release` function didn't exist on v4. Resolved by accepting the full function. - [x] Native avm-transpiler build succeeds - [x] Makefile targets verified: `avm-transpiler-cross-arm64-linux`, `bb-cpp-cross-arm64-linux` dependency corrected - [x] CMake preset verified: `zig-arm64-linux` has `AVM_TRANSPILER_LIB` pointing to correct cross-compiled path - [ ] Full cross-compilation validated in release CI Closes #20793 ClaudeBox log: http://ci.aztec-labs.com/596d4a62f30fd2f0-2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makefile: The bb-cpp-cross-arm64-linux target depended on avm-transpiler-native instead of a cross-compiled arm64-linux avm-transpiler, so the cross-compiled libavm_transpiler.a was never built. Adds the missing avm-transpiler-cross-arm64-linux target and fixes the dependency.
barretenberg-rs release: The release function would error out if generated Rust bindings (api.rs, generated_types.rs) weren't present, even though it's trivial to generate them. Now generates them on-the-fly instead of failing.
Follows up on #20814 which added avm-transpiler arm64-linux support.