fix: avoid inserting unused witnesses into circuit#20965
Merged
Conversation
Member
Author
|
@LeilaWang are protocol circuits frozen atm? This change should remove some nasty warnings which are being emitted by the compiler currently. |
LeilaWang
approved these changes
Mar 6, 2026
AztecBot
force-pushed
the
tf/avoid-returning-unused-witnesses-to-circuit
branch
from
b342c8f to
2948f22
Compare
This PR avoids returning extra values from unconstrained to constrained code just to drop them immediately
AztecBot
force-pushed
the
tf/avoid-returning-unused-witnesses-to-circuit
branch
from
2948f22 to
90a2fab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR avoids returning extra values from unconstrained to constrained code just to drop them immediately