feat: add public log filtering by tag#21561
Merged
nventuro merged 2 commits intomerge-train/fairiesfrom Mar 13, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The accumulate methods for public and contract class logs did not check txHash, fromBlock, or toBlock, relying on callers to handle them. This meant that certain filter combinations (e.g. txHash + afterLog) would silently ignore params. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
spalladino
approved these changes
Mar 13, 2026
AztecBot
pushed a commit
that referenced
this pull request
Mar 13, 2026
Reimplementation of #21471. I did the filtering in-memory as explained there due to lack of indices. Additionally I fixed a bug in which certain index tuples were ignored - e.g. if `afterLog` and `txHash` were both specified, `txHash` was ignored. --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
✅ Successfully backported to backport-to-v4-staging #21477. |
AztecBot
added a commit
that referenced
this pull request
Mar 14, 2026
BEGIN_COMMIT_OVERRIDE fix: orchestrator enqueue yield (#21286) chore: default multiplier (#21482) chore: update yarn.lock (#21479) chore: backport #21231 feat!: improve L2ToL1MessageWitness API to v4 (#21463) feat(rpc): add package version to RPC response headers (#21526) feat(ethereum): check VK tree root and protocol contracts hash in rollup compatibility (#21537) feat: add public log filtering by tag (#21561) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reimplementation of #21471. I did the filtering in-memory as explained there due to lack of indices.
Additionally I fixed a bug in which certain index tuples were ignored - e.g. if
afterLogandtxHashwere both specified,txHashwas ignored.