fix: guard decryptBufferCBC against non-block-aligned ciphertext#21573
Draft
AztecBot wants to merge 1 commit intomerge-train/spartanfrom
Draft
fix: guard decryptBufferCBC against non-block-aligned ciphertext#21573AztecBot wants to merge 1 commit intomerge-train/spartanfrom
AztecBot wants to merge 1 commit intomerge-train/spartanfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #21192 added tests expecting
decryptBufferCBCto return an empty buffer when given ciphertext whose length is not a multiple of 16 (the AES block size), but did not add the corresponding guard to the implementation. Barretenberg'saesDecryptprocesses whatever bytes it can, leading to a non-empty garbage result instead of the expected empty buffer.Adds an early return of an empty buffer in
decryptBufferCBCwhendata.lengthis 0 or not a multiple of 16.Test plan
yarn workspace @aztec/foundation test src/crypto/aes128/index.test.ts— all 5 tests passClaudeBox log: https://claudebox.work/s/5026ee69dbe528cb?run=1