Skip to content

fix: interactions clean up#21933

Merged
Thunkar merged 3 commits intomerge-train/fairiesfrom
gj/fix_interactions
Mar 24, 2026
Merged

fix: interactions clean up#21933
Thunkar merged 3 commits intomerge-train/fairiesfrom
gj/fix_interactions

Conversation

@Thunkar
Copy link
Copy Markdown
Contributor

@Thunkar Thunkar commented Mar 24, 2026

This PR attempts to improve our interaction classes.

Closes: #21875

  1. ) Addresses the aforementioned bug, where BatchCall wasn't forwarding the baked in interaction data (authwitnesses, capsules, extrahashedargs)
  2. ) Removes the stale returnReceipt option from DeployMethod. This is a remnant from when we were just returning the deployed contract. Now that the return type is complex object, it just doesn't make sense to have extra complexity

@Thunkar Thunkar requested review from benesjan and mverzilli March 24, 2026 06:06
@Thunkar Thunkar self-assigned this Mar 24, 2026
@Thunkar Thunkar requested a review from a team as a code owner March 24, 2026 06:06
@Thunkar Thunkar changed the title cleaned up fix: interactions clean up Mar 24, 2026
Copy link
Copy Markdown
Contributor

@benesjan benesjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Co-authored-by: Jan Beneš <janbenes1234@gmail.com>
@Thunkar Thunkar enabled auto-merge (squash) March 24, 2026 06:43
@Thunkar Thunkar merged commit fad6d5c into merge-train/fairies Mar 24, 2026
11 checks passed
@Thunkar Thunkar deleted the gj/fix_interactions branch March 24, 2026 07:00
github-merge-queue bot pushed a commit that referenced this pull request Mar 25, 2026
BEGIN_COMMIT_OVERRIDE
fix: interactions clean up (#21933)
fix(stdlib): decode `EthAddress`, `FunctionSelector` and wrapped field
structs in `AbiDecoder` (#21926)
fix: bot gas estimations (#21945)
refactor(aztec-nr): use logging wrappers in
compute_note_hash_and_nullifier (#21897)
feat: add error page mapping for incompatible oracles (#21943)
fix(pxe): robust error handling in message processing (#21093)
fix: make PXE#getSyncedBlockHeader a concurrency=1 job to prevent IDB tx
liveness issues (#21944)
fix(aztec-up): validate semver in uninstall to prevent path traversal
(#21892)
fix(aztec-up): add truncation protection to install scripts (#21896)
feat!: scoped capsules (#21533)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants