fix: fully validate txs retrieved from tx file store#21988
Merged
alexghr merged 1 commit intomerge-train/spartanfrom Mar 25, 2026
Merged
fix: fully validate txs retrieved from tx file store#21988alexghr merged 1 commit intomerge-train/spartanfrom
alexghr merged 1 commit intomerge-train/spartanfrom
Conversation
spalladino
approved these changes
Mar 25, 2026
alexghr
force-pushed
the
ag/fix-tx-validation
branch
from
2027026 to
7254f7d
Compare
Collaborator
|
❌ Failed to cherry-pick to |
alexghr
added a commit
that referenced
this pull request
Mar 25, 2026
#21998) ## Summary Backport of #21988 to v4. Adds full transaction validation (via `TxValidator`) to txs retrieved from the tx file store and node RPC sources, replacing the previous hash-only validation. This ensures downloaded txs are validated with the same rigor as txs received via p2p. ## Cherry-pick details - **Commit 1**: Raw cherry-pick with conflict markers in `yarn-project/p2p/src/client/factory.ts` - **Commit 2**: Conflict resolution — simplified import to only include functions used in this file The conflict was minor: the v4 branch had a single-line import while `next` had a multi-line import block with additional unused imports (`createCheckAllowedSetupCalls`, `getDefaultAllowedSetupFunctions`). Resolved by importing only the two functions actually used. ## Verification - Build passes (`yarn build`) - All related tests pass: - `p2p/src/services/tx_collection/tx_source.test.ts` (3/3) - `p2p/src/services/tx_file_store/tx_file_store.test.ts` (17/17) - `foundation/src/collection/array.test.ts` (61/61) ClaudeBox log: https://claudebox.work/s/9c69d8936952bb70?run=1 --------- Co-authored-by: Alex Gherghisan <alexghr@users.noreply.github.com>
alexghr
added a commit
that referenced
this pull request
Mar 25, 2026
#21998) ## Summary Backport of #21988 to v4. Adds full transaction validation (via `TxValidator`) to txs retrieved from the tx file store and node RPC sources, replacing the previous hash-only validation. This ensures downloaded txs are validated with the same rigor as txs received via p2p. ## Cherry-pick details - **Commit 1**: Raw cherry-pick with conflict markers in `yarn-project/p2p/src/client/factory.ts` - **Commit 2**: Conflict resolution — simplified import to only include functions used in this file The conflict was minor: the v4 branch had a single-line import while `next` had a multi-line import block with additional unused imports (`createCheckAllowedSetupCalls`, `getDefaultAllowedSetupFunctions`). Resolved by importing only the two functions actually used. ## Verification - Build passes (`yarn build`) - All related tests pass: - `p2p/src/services/tx_collection/tx_source.test.ts` (3/3) - `p2p/src/services/tx_file_store/tx_file_store.test.ts` (17/17) - `foundation/src/collection/array.test.ts` (61/61) ClaudeBox log: https://claudebox.work/s/9c69d8936952bb70?run=1 --------- Co-authored-by: Alex Gherghisan <alexghr@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 27, 2026
BEGIN_COMMIT_OVERRIDE fix: only clear provenBlockNumber when it exceeds prune point (#21946) chore: (A-779) load all accounts before calling LogService.#getSecretsForSenders (#21923) fix: align staging-public mana target with testnet/mainnet (#21983) chore: (A-777) add warn logs for regressive path in block synchronizer (#21925) fix: fully validate txs retrieved from tx file store (#21988) refactor: extract checkpoint proposal handling to ProposalHandler (#21999) fix: unbounded memory in calldataRetriever (#22004) fix(p2p): check peer rate limit before global to prevent quota starvation (#21997) fix(p2p): evict expired failed-auth-handshake entries on heartbeat (#21992) chore: defensively handle skipPushProposedBlocksToArchiver (#22017) chore: bump testnet prover resource profile to prod-hi-tps (#22019) chore: (A-835) remove unused serializer (#22037) fix(p2p): remove disconnected peers from scoring maps (#22009) fix(e2e): set anvilSlotsInAnEpoch in slashing tests (#21869) fix(ethereum): Audit fixes A-810, A-812 (nonce race, isEscapeHatchOpen logging) (#21948) chore: remove old TxPool implementation (#22028) fix: Fix blob encoding when uploaded from proposals (#22045) chore: Adds /cycle and /fix skills. Also configures linear mcp server (#22043) chore: remove validatorReexecute config option (#22024) fix(sequencer): use last L1 slot of L2 slot as eth_simulateV1 timestamp (#22023) docs(simulator): clarify teardown gas billing is intentional (#22057) chore: revert account loading optimization in log service (#22062) fix: use DateProvider in PeerScoring (#22070) fix(aztec.js): preserve extraHashedArgs in DeployMethod.with() (#22053) fix(p2p): replace process.exit() with graceful shutdown in worker cleanup (#22046) chore: merge next (#22089) fix(stdlib): correct NoteDao size (#22068) feat: improve blob download from filestores (#22096) fix: remove stale tx_pool v1 benchmark reference (#22104) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.