fix: address flake in fee settings test#21991
Merged
Conversation
Merged
PhilWindle
approved these changes
Mar 25, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Maddiaa0
approved these changes
Mar 26, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
LHerskind
force-pushed
the
lh/a-874-flake-in-fee_settings
branch
from
f0080c4 to
52771b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fee_settings.test.tscould flake because its twoproveTxcalls could read differentgetCurrentMinFees()values if the node synced L1 state in between. This change makes the behavior test deterministic by waiting until the deploy block is checkpointed, taking a baseline fee snapshot, and preparing both transactions against controlled fee snapshots. It also adds a deterministic regression test that forces different fee snapshots for the twoproveTxcalls and reproduces the original stale-snapshot race directly.`