fix: Windows cross-compilation — unsigned long vs size_t in polynomial_arithmetic.hpp#22073
Merged
fix: Windows cross-compilation — unsigned long vs size_t in polynomial_arithmetic.hpp#22073
Conversation
… header The implementation (.cpp) already uses size_t but the header declared unsigned long. On Linux these are the same type, but on Windows LLP64 unsigned long is 32-bit while size_t is 64-bit, causing -Wshorten-64-to-32 when passing domain.size (size_t) to the parameter. Also ran clang-format to fix alignment.
AztecBot
added
ci-draft
Adds explicit flake pattern for this test which hit a flake during ci-release-pr CI run on PR #22073.
Contributor
|
Merging skipping CI - these are just clang formatting changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Windows cross-compilation failure on v4-next. Replaces previous PR #22072 which merged without CI validation.
The header
polynomial_arithmetic.hppdeclaresunsigned long num_coeffsbut the implementation (.cpp) usesconst size_t num_coeffs. On Linux these are the same type, but on Windows LLP64unsigned longis 32-bit whilesize_tis 64-bit, causing-Wshorten-64-to-32when passingdomain.size(size_t).This function was removed on
nextbefore Windows cross-compilation was added, so it was never caught there. It's v4-specific legacy code.Also includes clang-format fix (the previous PR had format violations).
CI failure: https://github.com/AztecProtocol/aztec-packages/actions/runs/23608075427/job/68756199559
ClaudeBox log: https://claudebox.work/s/fe9af88896e7e6d6?run=11