Skip to content

feat!: remove ALL_SCOPES (backport #22136)#22161

Merged
mverzilli merged 1 commit intobackport-to-v4-next-stagingfrom
claudebox/70a27ab4c3eaf4ea-2
Mar 30, 2026
Merged

feat!: remove ALL_SCOPES (backport #22136)#22161
mverzilli merged 1 commit intobackport-to-v4-next-stagingfrom
claudebox/70a27ab4c3eaf4ea-2

Conversation

@AztecBot
Copy link
Copy Markdown
Collaborator

@AztecBot AztecBot commented Mar 30, 2026

Summary

Backport of #22136 to v4-next, stacked on #22157 (backport of #22113 scoped capsules).

Removes the ALL_SCOPES option and AccessScopes type, forcing all callers to explicitly specify which addresses are in scope via AztecAddress[]. This is a breaking change in the PXE/wallet interface.

Stacking

This PR is stacked on claudebox/backport-22113-scoped-capsules (#22157) which introduces CapsuleService. With that base in place, the cherry-pick applies cleanly with no conflicts.

@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels Mar 30, 2026
@AztecBot
Copy link
Copy Markdown
Collaborator Author

AztecBot commented Mar 30, 2026

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/7e481ec0b0534f6e�7e481ec0b0534f6e8;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_p2p/add_rollup.test.ts (371s) (code: 0) group:e2e-p2p-epoch-flakes

This is a breaking change in the interface between PXE and wallets. 

ALL_SCOPES allowed wallets to request PXE to run operations "for all its
known accounts". This PR removes that option and forces all layers of
the system to explicitly state which addresses to use as scope by
providing an array of addresses. An empty array now means "no account in
scope" (it used to default to "ALL_SCOPES" particularly when executing
utilities).
@AztecBot AztecBot changed the base branch from backport-to-v4-next-staging to claudebox/backport-22113-scoped-capsules March 30, 2026 17:44
@AztecBot AztecBot force-pushed the claudebox/70a27ab4c3eaf4ea-2 branch from 87a4869 to 19daacc Compare March 30, 2026 17:44
Base automatically changed from claudebox/backport-22113-scoped-capsules to backport-to-v4-next-staging March 30, 2026 17:56
@mverzilli mverzilli marked this pull request as ready for review March 30, 2026 17:59
@mverzilli mverzilli merged commit d79af8a into backport-to-v4-next-staging Mar 30, 2026
22 of 26 checks passed
@mverzilli mverzilli deleted the claudebox/70a27ab4c3eaf4ea-2 branch March 30, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants