Skip to content

docs: fix aztec-nr v4.2.0 documentation issues from audit#22166

Merged
AztecBot merged 1 commit intonextfrom
docs/aztec-nr-v4.2.0-doc-audit-fixes
Apr 1, 2026
Merged

docs: fix aztec-nr v4.2.0 documentation issues from audit#22166
AztecBot merged 1 commit intonextfrom
docs/aztec-nr-v4.2.0-doc-audit-fixes

Conversation

@critesjosh
Copy link
Copy Markdown
Contributor

Summary

  • Fix 52 issues across all aztec-nr doc pages identified during a manual review against nargo 1.0.0-beta.18 and local Aztec network v4.2.0-aztecnr-rc.2
  • Fixes applied to both docs-developers/ (source) and developer_versioned_docs/version-v4.2.0-aztecnr-rc.2/ (versioned copy)
  • Key categories: deprecated import paths, missing API parameters (capsule scope), non-existent methods (simulate_utility, msg_sender().unwrap()), incorrect struct names, out-of-bounds array access in code examples, wrong dependency URLs, stale content removal

Critical fixes (would cause compilation failures if copied from docs)

  • Add missing scope parameter to all capsule API examples
  • Fix CapsuleArray::at() call signature (2 args → 3)
  • Fix out-of-bounds array access in sort_efficient example
  • Update debug_log import path (dep::aztec::oracle::debug_logaztec::oracle::logging)
  • Replace simulate_utility() with execute_utility()
  • Fix NoteMessagePendingDeliveryNoteMessage
  • Correct partial note commitment structure (storage_slot in completion phase, not partial phase)

Other fixes

  • Update all dep:: import prefixes to current unprefixed style
  • Fix dependency URLs from aztec-packages repo to aztec-nr repo
  • Correct ONCHAIN_CONSTRAINED link that pointed to ONCHAIN_UNCONSTRAINED
  • Remove stale TODO comments, placeholder image, delegate_call references
  • Update pedersen → poseidon2, return_values: BoundedVecreturn_hash: Field
  • Fix variable name mismatch (TWO_POW_32TWO_POW_16)
  • Add missing unconstrained keyword to utility function examples
  • Add missing #[derive] attributes on NFTNote in AIP-721

Test plan

  • Verify docs build succeeds (yarn build in docs/)
  • Spot-check code examples against source at v4.2.0-aztecnr-rc.2 tag
  • Review rendered pages for formatting issues

@critesjosh critesjosh requested a review from a team March 30, 2026 20:48
@AztecBot AztecBot force-pushed the docs/aztec-nr-v4.2.0-doc-audit-fixes branch from 7f1bd43 to 2626b7c Compare April 1, 2026 13:22
@AztecBot AztecBot enabled auto-merge April 1, 2026 13:23
## Summary

- Fix 52 issues across all aztec-nr doc pages identified during a manual review against `nargo 1.0.0-beta.18` and local Aztec network `v4.2.0-aztecnr-rc.2`
- Fixes applied to both `docs-developers/` (source) and `developer_versioned_docs/version-v4.2.0-aztecnr-rc.2/` (versioned copy)
- Key categories: deprecated import paths, missing API parameters (capsule `scope`), non-existent methods (`simulate_utility`, `msg_sender().unwrap()`), incorrect struct names, out-of-bounds array access in code examples, wrong dependency URLs, stale content removal

### Critical fixes (would cause compilation failures if copied from docs)
- Add missing `scope` parameter to all capsule API examples
- Fix `CapsuleArray::at()` call signature (2 args → 3)
- Fix out-of-bounds array access in `sort_efficient` example
- Update `debug_log` import path (`dep::aztec::oracle::debug_log` → `aztec::oracle::logging`)
- Replace `simulate_utility()` with `execute_utility()`
- Fix `NoteMessagePendingDelivery` → `NoteMessage`
- Correct partial note commitment structure (`storage_slot` in completion phase, not partial phase)

### Other fixes
- Update all `dep::` import prefixes to current unprefixed style
- Fix dependency URLs from `aztec-packages` repo to `aztec-nr` repo
- Correct `ONCHAIN_CONSTRAINED` link that pointed to `ONCHAIN_UNCONSTRAINED`
- Remove stale TODO comments, placeholder image, delegate_call references
- Update pedersen → poseidon2, `return_values: BoundedVec` → `return_hash: Field`
- Fix variable name mismatch (`TWO_POW_32` → `TWO_POW_16`)
- Add missing `unconstrained` keyword to utility function examples
- Add missing `#[derive]` attributes on `NFTNote` in AIP-721

## Test plan
- [ ] Verify docs build succeeds (`yarn build` in docs/)
- [ ] Spot-check code examples against source at `v4.2.0-aztecnr-rc.2` tag
- [ ] Review rendered pages for formatting issues
@AztecBot AztecBot force-pushed the docs/aztec-nr-v4.2.0-doc-audit-fixes branch from 2626b7c to 06a09f0 Compare April 1, 2026 13:25
@AztecBot AztecBot added this pull request to the merge queue Apr 1, 2026
Merged via the queue into next with commit 135e8e0 Apr 1, 2026
19 checks passed
@AztecBot AztecBot deleted the docs/aztec-nr-v4.2.0-doc-audit-fixes branch April 1, 2026 14:04
@AztecBot
Copy link
Copy Markdown
Collaborator

AztecBot commented Apr 1, 2026

❌ Failed to cherry-pick to v4-next due to conflicts. (🤖) View backport run.

AztecBot pushed a commit that referenced this pull request Apr 1, 2026
…t (with conflicts)

Cherry-pick of 06a09f0 from PR #22166.
All conflicts are modify/delete in versioned docs directory that was removed on v4-next.
critesjosh added a commit that referenced this pull request Apr 1, 2026
…22166) (#22227)

## Summary

Backport of #22166
to v4-next.

Fixes 52 documentation issues across aztec-nr doc pages (deprecated
import paths, missing API parameters, incorrect method names, wrong
dependency URLs, etc.).

## Conflict resolution

All 20 conflicts were modify/delete in
`docs/developer_versioned_docs/version-v4.2.0-aztecnr-rc.2/` — this
versioned docs directory does not exist on v4-next, so the deletions
were accepted. The 18 `docs-developers/` source files merged cleanly.

## Commits

1. Cherry-pick with conflicts (original attempt)
2. Conflict resolution (remove versioned docs that don't exist on
v4-next)
3. No build fixes needed (docs-only change)

ClaudeBox log: https://claudebox.work/s/78234c172376f4ce?run=1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants